"retry_policy" supports only one "retry_on" condition

Description Envoy allows to provide more than one “retry_on” condition in “retry_policy” i.e.

"retry_policy": {
"retry_on": "connect-failure,retriable-status-codes,refused-stream",
"num_retries": 2
}

However, using

"retry_on": "connect-failure,retriable-status-codes,refused-stream"

in Ambassador’s mapping config results in error in Ambassador retry policy configuration.

Steps to reproduce the behavior:

1. Create mapping with specified “retry_policy” with more than one “retry_on” condition i.e.

      apiVersion: ambassador/v1
      kind:  Mapping
      name: {{ include "xxx.yyy.zzz .}}_mapping
      prefix: /{{ include "ccc.vvv.bbb" .}}
      service: https://{{ include "ccc.vvv.bbb" .}}.{{ .Release.Namespace }}.svc.cluster.local.:80
      tls: upstream
      retry_policy:
        retry_on: "connect-failure,5xx,retriable-4xx,"
        num_retries: 2

1. Apply mapping from above.

2. See error in Ambassador Diagnostic Overview -> ir.retrypolicy: Invalid retry policy specified: <IRRetryPolicy ir.retrypolicy>

Expected behavior Ambassador’s retry policy should be able to handle multiple values in “retry_on” to reflect Envoy retry capabilities.

Affected version Affected version -> Ambassador: 0.61.1

Additional context Method that validates “retry_on” value:

ambassador/ambassador/ir/irretrypolicy.py

 def validate_retry_policy(self) -> bool:
        retry_on = self.get('retry_on', None)

        is_valid = False
        if retry_on in [ '5xx', 'gateway-error', 'connect-failure', 'retriable-4xx', 'refused-stream', 'retriable-status-codes' ]:
            return True

        return is_valid

[kflynn]

Yeah, let me see how to get this in…

[justinfiore]

Can we reopen this? We would also like to be able to specify multiple retry_on values. In particular, is there any way to retry on just 502 and 503 and connect-failure and refused-stream? i.e. I don’t want to retry on 504’s or 500’s