Using includeSubdomains: true in a Filter causes crash in Ambassador 1.5.4

Describe the bug Using includeSubdomains: true in a Filter causes ambassador to crash at startup, or to raise an error when the Filter is added.

To Reproduce Steps to reproduce the behavior:

1. Apply a Filter with includeSubdomains: true set for one of its spec.OAuth2.protectedOrigins
2. Check logs for error or attempt to access a site included as part of the Filter

Expected behavior The Filter should not error and should properly protect subdomains as expected.

Versions (please complete the following information):

• Ambassador: 1.5.4
• Kubernetes environment: EKS
• Version: 1.14

Additional context Here is the Filter which causes issues:

apiVersion: getambassador.io/v2
kind: Filter
metadata:
  name: my-test
spec:
  OAuth2:
    authorizationURL: https://cognito-idp.us-east-1.amazonaws.com/{sensitive}
    clientID: {sensitive}
    secret: {sensitive}
    protectedOrigins:
      - origin: https://my-test.{sensitive}
        includeSubdomains: true

Removing includeSubdomains: true, as shown below, allows the Filter to apply correctly and start working.

apiVersion: getambassador.io/v2
kind: Filter
metadata:
  name: my-test
spec:
  OAuth2:
    authorizationURL: https://cognito-idp.us-east-1.amazonaws.com/{sensitive}
    clientID: {sensitive}
    secret: {sensitive}
    protectedOrigins:
      - origin: https://my-test.{sensitive}

gz#453

[khussey]

This fix is in 1.7.0, which is now available.

[khussey]

Oops, closed prematurely. We have a fix and will be shipping it with 1.7.0 in the coming days.