Implement http_version attribute on BaseResponse object

Currently, I am utilizing requests, which under the hood uses urllib3, whose HTTPResponse object contains a .version attribute, which is an int, ten times greater than the actual HTTP version (i.e. 10 for 1.0, 11 for 1.1, etc). I currently use it for logging my requests and responses in debug mode.

It would be good I think to implement a similar attribute (either version or more specifically http_version) for the BaseResponse object, for similar purposes, but perhaps use an actual float. What are your thoughts?

Proposal: BaseResponse.http_version: float = 0.0 # Could be a floatEnum with known HTTP versions

[tomchristie]

Yup. So we’ve got response.protocol, which is a string and right now can be either "HTTP/2" or "HTTP/1.1".

We actually ought to improve on that by using the .http_version that h11 returns in order to return "HTTP/1.0" or "HTTP/0.9" when appropriate.

Its also possible that we might want to include a .protocol_value property which returns tuples such as eg. (1, 1) , (2, 0).

[StephenBrown2]

I wouldn’t necessarily switch to http_version, as protocol makes sense the way that it is now, I’d just mention it in the API compatibility docs.