Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Error in app startup event is not logged and does not prevent startup

See original GitHub issue

Scenario: I have a ‘startup’ event handler:

@app.on_event('startup')
async def startup():
    initialise()

and I am running under uvicorn for local dev just via the:

if __name__ == '__main__':
    uvicorn.run(app, host='0.0.0.0', port=8000)

If there is an uncaught exception in the startup event handler, the exception will be swallowed (not logged) and uvicorn will continue to startup.

The only anomaly seen in the logs is that uvicorn will report:

ASGI 'lifespan' protocol appears unsupported

I would like to see:

the exception and traceback logged
process aborted, since we haven’t fully started up yet

Issue Analytics

State:
Created 4 years ago
Reactions:14
Comments:8 (4 by maintainers)

Top GitHub Comments

21reactions

florimondmancacommented, May 31, 2019

@madkote A fix is waiting for review in #488. Feel free to take a look!

Also, keep in mind that maintainers/contributors work on open source projects in their free time (for the large majority). A more gentle « Is there a fix for this yet? » would have been more appropriate. 😃

6reactions

kiddtencommented, Apr 24, 2019

Since I’m using unicorn via cli option --lifespan on helped me