get_directories in staticfiles.py has bad asserts

I don’t think you can use F-Strings in assert statements. I get “invalid syntax” if I try.

The line: directory = os.path.normpath(os.path.join(spec.origin, "..", "statics")) Always assumes there is a folder statics? I believe the standard is static and not statics and the user is not given the option to circumvent the step. Does it make more sense to only include this step if directory is None.

The directory argument does not get the package path prepended, which I feel is implied in the documentation.

The assert os.path.isdir(directory) will fail every time since it will return the __init__.py of a package.

[tomchristie]

Closed via #535 and released as 0.12.3.

Happy to also resconsider our static dir naming, but let’s treat that as a sperate issue if anyone wants to open it.

[dmontagu]

@tomchristie this page of the Django docs says:

Files are searched by using the enabled finders. The default is to look in all locations defined in STATICFILES_DIRS and in the ‘static’ directory of apps specified by the INSTALLED_APPS setting.

I believe this is reflected in the code here.