Testing randomly fails

I run ./scripts/test to check if everything is ok. Sometimes tests are passed, sometimes - no. This happens randomly.

Here are fails:

========================================================================= FAILURES ==========================================================================
_______________________________________________________________________ test_headers ________________________________________________________________________

    def test_headers():
        h = Headers(raw=[(b"a", b"123"), (b"a", b"456"), (b"b", b"789")])
        assert "a" in h
        assert "A" in h
        assert "b" in h
        assert "B" in h
        assert "c" not in h
        assert h["a"] == "123"
        assert h.get("a") == "123"
        assert h.get("nope", default=None) is None
        assert h.getlist("a") == ["123", "456"]
        assert h.keys() == ["a", "a", "b"]
        assert h.values() == ["123", "456", "789"]
        assert h.items() == [("a", "123"), ("a", "456"), ("b", "789")]
        assert list(h) == ["a", "a", "b"]
        assert dict(h) == {"a": "123", "b": "789"}
        assert repr(h) == "Headers(raw=[(b'a', b'123'), (b'a', b'456'), (b'b', b'789')])"
        assert h == Headers(raw=[(b"a", b"123"), (b"b", b"789"), (b"a", b"456")])
        assert h != [(b"a", b"123"), (b"A", b"456"), (b"b", b"789")]

        h = Headers({"a": "123", "b": "789"})
        assert h["A"] == "123"
        assert h["B"] == "789"
>       assert h.raw == [(b"a", b"123"), (b"b", b"789")]
E       AssertionError: assert [(b'b', b'789...b'a', b'123')] == [(b'a', b'123'...b'b', b'789')]
E         At index 0 diff: (b'b', b'789') != (b'a', b'123')
E         Use -v to get the full diff

tests/test_datastructures.py:145: AssertionError
_____________________________________________________________________ test_queryparams ______________________________________________________________________

    def test_queryparams():
        q = QueryParams("a=123&a=456&b=789")
        assert "a" in q
        assert "A" not in q
        assert "c" not in q
        assert q["a"] == "456"
        assert q.get("a") == "456"
        assert q.get("nope", default=None) is None
        assert q.getlist("a") == ["123", "456"]
>       assert list(q.keys()) == ["a", "b"]
E       AssertionError: assert ['b', 'a'] == ['a', 'b']
E         At index 0 diff: 'b' != 'a'
E         Use -v to get the full diff

tests/test_datastructures.py:182: AssertionError
_______________________________________________________________________ test_formdata _______________________________________________________________________

    def test_formdata():
        upload = io.BytesIO(b"test")
        form = FormData([("a", "123"), ("a", "456"), ("b", upload)])
        assert "a" in form
        assert "A" not in form
        assert "c" not in form
        assert form["a"] == "456"
        assert form.get("a") == "456"
        assert form.get("nope", default=None) is None
        assert form.getlist("a") == ["123", "456"]
>       assert list(form.keys()) == ["a", "b"]
E       AssertionError: assert ['b', 'a'] == ['a', 'b']
E         At index 0 diff: 'b' != 'a'
E         Use -v to get the full diff

tests/test_datastructures.py:215: AssertionError
______________________________________________________________________ test_multidict _______________________________________________________________________

    def test_multidict():
        q = MultiDict([("a", "123"), ("a", "456"), ("b", "789")])
        assert "a" in q
        assert "A" not in q
        assert "c" not in q
        assert q["a"] == "456"
        assert q.get("a") == "456"
        assert q.get("nope", default=None) is None
        assert q.getlist("a") == ["123", "456"]
>       assert list(q.keys()) == ["a", "b"]
E       AssertionError: assert ['b', 'a'] == ['a', 'b']
E         At index 0 diff: 'b' != 'a'
E         Use -v to get the full diff

tests/test_datastructures.py:239: AssertionError

[em92]

I will try ordered dict then

[tomchristie]

Either we can add sorted to either side of the test comparisons, or you could use an OrderedDict in the datastructures implementations.