Further timeouts and resource limiting.

• --timeout-request-start (Timeout unless request headers complete within this time. ~10s)
• --timeout-request-complete (Timeout if request body is still being read after this time. ~60s)
• ~–limit-request-line-size (4096, See gunicorn)~
• ~–limit-request-header-size (8190, See gunicorn)~
• ~–limit-request-header-count (100, See gunicorn)~
• --limit-ws-message-size

@Kludex notes

• We are not going to implement --limit-request-header-count. The header size limitation is enough.
• Should we consider timeout on startup and shutdown lifespans?

[Kludex]

I think --limit-request-header-size can be considered equivalent to h11-max-incomplete-event-size in the h11 implementation, which we already have.

EDIT: Actually, the h11-max-incomplete-event-size is a replacement for both --limit-request-header-size and --limit-request-line-size:

max_incomplete_event_size (int) – The maximum number of bytes we’re willing to buffer of an incomplete event. In practice this mostly sets a limit on the maximum size of the request/response line + headers. If this is exceeded, then next_event() will raise RemoteProtocolError.

Ref.: https://h11.readthedocs.io/en/latest/api.html#h11.Connection

[hoopes]

Hello,

Apologies for chiming in on this, but my use case could really use this feature. I have a very large sql query that uses sqlalchemy (so it is not async, from the start). This is an internal “big data” app, so there is no pressure for super low latency per request. I’m streaming lines of json with a starlette StreamingResponse from a fastapi application.

However, the query takes about 90-120 seconds to get started actually producing results. uvicorn appears to time out, whether i run it directly or under gunicorn. daphne has a timeout arg, so i’m using that now. I’d really like to use uvicorn as a work in gunicorn, to get easy multi-process service.

Anyway, I just wanted to bump this. If you pointed me to the code where the timeout actually occurs, I might be interested in trying a PR, if you’d be interested (at least for the request start, and the others if they fall out easily).

Thanks!