Handle exception when receive request with custom method

Checklist

• The bug is reproducible against the latest release or master.
• There are no similar issues or pull requests to fix it yet.

Describe the bug

I’m developing fastapi application which is using starlette and run with uvicorn.

Currently I developing locally on my PC which I’ve done for a long time, so I frequently get some external random requests from the internet from random IPs.

While it is fine if I get some request that lead to some php endpoint and server log it and show nice 404 error in the logs, sometimes I get weird custom requests that break uvicorn and it throw errors, it look like this in the console:

The main issue in /uvicorn/protocols/http/httptools_impl.py: https://github.com/encode/uvicorn/blob/a9ea657339e64c2236f3fb49616e3e0a133273c1/uvicorn/protocols/http/httptools_impl.py#L131-L138

Steps to reproduce the bug

• Use curl to make custom request, the custom method is -X flag where you in theory should use GET/POST/… but instead in my case I get some weird methods, that make uvicorn to throw exception

curl -X MUX -i -H "Custom-Header: Test" http://127.0.0.1/

Expected behavior

I should get minimal and useful log, this may be need to pass on underlying libraries (to handle it there) or being able to control behavior from them. Right now when you get this as it shows you don’t understand what is happening, who is sending to you (IP) and what (what method?).

Actual behavior

Logs get full of this exception spam, it essentially work as DDoS for a server. I have to patch library manually to be able to fix this.

Debugging material

I attach screenshot above, there is also example from one request:

WARNING:  Invalid HTTP request received.
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py", line 131, in data_received
    self.parser.feed_data(data)
  File "httptools/parser/parser.pyx", line 212, in httptools.parser.parser.HttpParser.feed_data
httptools.parser.errors.HttpParserInvalidMethodError: Invalid method encountered

First line is come, probably from fastapi and other are exception.

Environment

• Windows, WSL, Docker
• Running uvicorn 0.15.0 with CPython 3.8.6 on Windows
• Running fastapi application like that: uvicorn main:app --host 0.0.0.0 --port 80

Additional context

This is similar issues:

• https://github.com/encode/uvicorn/issues/75
• https://stackoverflow.com/questions/65878595/invalid-http-method-in-traceback-uvicorn
• https://stackoverflow.com/questions/69961123/host-fastapi-backend-api-and-react-app-frontend-locally
• https://github.com/encode/uvicorn/issues/1364

[euri10]

yep, you’ll just see WARNING: Invalid HTTP request received. and not the full traceback anymore, there’s no functional change

[michealroberts]

@Kludex I feel like there is an issue, because this basically stops the server from reporting a healthy status to the kubernetes pod health checker, as it is causing it to reload and then shutdown after 5-10 invalid HTTP requests. The issue doesn’t happen on local, and those get requests are coming from the liveness probe. It’s definitely a uvicorn issue, because I have had multiple different servers running on kubernetes but uvicorn has so far been very problematic. Happy to be educated…of course!