Action doesn't support PRs

- name: Commit new expectations
      if: failure() && github.actor != 'patrickhulce' && github.actor != 'brendankenny'
      uses: EndBug/add-and-commit@v4
      with:
        cwd: ${{ github.workspace }}/lighthouse
        add: lighthouse-core/scripts/chromium-web-tests/webtests
        message: update webtest expectations
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

results

2020-07-30T17:18:06.7641560Z ##[group]Run EndBug/add-and-commit@v4
2020-07-30T17:18:06.7641780Z with:
2020-07-30T17:18:06.7641920Z   cwd: /Users/runner/work/lighthouse/lighthouse/lighthouse
2020-07-30T17:18:06.7642060Z   add: lighthouse-core/scripts/chromium-web-tests/webtests
2020-07-30T17:18:06.7642190Z   message: update webtest expectations
2020-07-30T17:18:06.7642310Z   force: false
2020-07-30T17:18:06.7642430Z   signoff: false
2020-07-30T17:18:06.7642520Z env:
2020-07-30T17:18:06.7643020Z   DEPOT_TOOLS_PATH: /Users/runner/work/lighthouse/lighthouse/depot-tools
2020-07-30T17:18:06.7643180Z   DEVTOOLS_PATH: /Users/runner/work/lighthouse/lighthouse/devtools-frontend
2020-07-30T17:18:06.7643320Z   BLINK_TOOLS_PATH: /Users/runner/work/lighthouse/lighthouse/blink_tools
2020-07-30T17:18:06.7643660Z   PATH: /Users/runner/work/lighthouse/lighthouse/depot-tools:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.6.0/bin:/usr/local/opt/ruby/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/usr/local/go/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.3.1/x64
2020-07-30T17:18:06.7645500Z   GITHUB_TOKEN: ***
2020-07-30T17:18:06.7645680Z ##[endgroup]
2020-07-30T17:18:06.8307770Z ##[warning]Unable to fetch author info: couldn't find commit.
2020-07-30T17:18:06.8310040Z Using 'Add & Commit Action <[e-mail]>' as author.
2020-07-30T17:18:07.0264680Z ##[group]Internal logs
2020-07-30T17:18:07.0266530Z Running in /Users/runner/work/lighthouse/lighthouse/lighthouse.
2020-07-30T17:18:07.0267290Z Staging files...
2020-07-30T17:18:07.0818220Z Checking for uncommitted changes in the git working tree...
2020-07-30T17:18:13.0685140Z From https://github.com/GoogleChrome/lighthouse
2020-07-30T17:18:13.0703980Z  * [new branch]      520viewer               -> origin/520viewer
2020-07-30T17:18:13.0723380Z  * [new branch]      78a1a8f                 -> origin/78a1a8f
... snip ...
2020-07-30T17:18:13.9081000Z Creating branch...
2020-07-30T17:18:13.9081220Z Switching branch...
2020-07-30T17:18:13.9082160Z M	lighthouse-core/scripts/chromium-web-tests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
2020-07-30T17:18:13.9082410Z Pulling from remote...
2020-07-30T17:18:13.9082610Z Resetting files...
2020-07-30T17:18:13.9082830Z Unstaged changes after reset:
2020-07-30T17:18:13.9084080Z M	lighthouse-core/scripts/chromium-web-tests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
2020-07-30T17:18:13.9084310Z Adding files...
2020-07-30T17:18:13.9084500Z Removing files...
2020-07-30T17:18:13.9084660Z Creating commit...
2020-07-30T17:18:13.9084920Z [1176/merge eb1d6c829] update webtest expectations
2020-07-30T17:18:13.9085880Z  1 file changed, 2 insertions(+), 2 deletions(-)
2020-07-30T17:18:13.9086140Z Tagging commit...
2020-07-30T17:18:13.9086360Z Pushing commits to repo...
... snip ...
2020-07-30T17:18:13.9211750Z Switched to branch '1176/merge'
2020-07-30T17:18:13.9212410Z warning: Pulling without specifying how to reconcile divergent branches is
2020-07-30T17:18:13.9212810Z discouraged. You can squelch this message by running one of the following
2020-07-30T17:18:13.9213080Z commands sometime before your next pull:
2020-07-30T17:18:13.9213160Z 
2020-07-30T17:18:13.9213380Z   git config pull.rebase false  # merge (the default strategy)
2020-07-30T17:18:13.9213570Z   git config pull.rebase true   # rebase
2020-07-30T17:18:13.9214200Z   git config pull.ff only       # fast-forward only
2020-07-30T17:18:13.9214290Z 
2020-07-30T17:18:13.9214960Z You can replace "git config" with "git config --global" to set a default
2020-07-30T17:18:13.9215670Z preference for all repositories. You can also pass --rebase, --no-rebase,
2020-07-30T17:18:13.9216380Z or --ff-only on the command line to override the configured default per
2020-07-30T17:18:13.9216630Z invocation.
2020-07-30T17:18:13.9216750Z 
2020-07-30T17:18:13.9216960Z There is no tracking information for the current branch.
2020-07-30T17:18:13.9217240Z Please specify which branch you want to merge with.
2020-07-30T17:18:13.9217830Z See git-pull(1) for details.
2020-07-30T17:18:13.9217970Z 
2020-07-30T17:18:13.9218150Z     git pull <remote> <branch>
2020-07-30T17:18:13.9218220Z 
2020-07-30T17:18:13.9218500Z If you wish to set tracking information for this branch you can do so with:
2020-07-30T17:18:13.9218630Z 
2020-07-30T17:18:13.9219170Z     git branch --set-upstream-to=origin/<branch> 1176/merge
2020-07-30T17:18:13.9219330Z 
2020-07-30T17:18:17.3261630Z remote: 
2020-07-30T17:18:17.3263040Z remote: Create a pull request for '1176/merge' on GitHub by visiting:        
2020-07-30T17:18:17.3263530Z remote:      https://github.com/GoogleChrome/lighthouse/pull/new/1176/merge        
2020-07-30T17:18:17.3263770Z remote: 
2020-07-30T17:18:17.3293910Z To https://github.com/GoogleChrome/lighthouse
2020-07-30T17:18:17.3294840Z  * [new branch]          1176/merge -> 1176/merge
2020-07-30T17:18:17.3367900Z Branch '1176/merge' set up to track remote branch '1176/merge' from 'origin'.
2020-07-30T17:18:17.3371130Z Pushing tags to repo...
2020-07-30T17:18:17.6857510Z Everything up-to-date
2020-07-30T17:18:17.6881390Z Branch '1176/merge' set up to track remote branch '1176/merge' from 'origin'.

ref https://github.com/GoogleChrome/lighthouse/runs/928694099?check_suite_focus=true#step:20:332

It seems that GITHUB_REF is set to 1176/merge, a branch that GitHub made which merges master into the PR branch before running the tests. If GitHub does that, how can this action commit to the PR branch directly?

[rlejeune]

Hi!

I’ll try to set the branch name as suggested

Thank you 😃

[EndBug]

The changes have been released with version v4.4.0 (that can also be accessed via v4 and latest). Please update the ref in your workflow so that I can delete the pr-support branch (I’ll write in the comments of your workflow too 😉)

Thanks again for the issue 👍