Action fails when `add` or `remove` only contain a space

I suppose what I could do here is simply have 2 steps with conditionals, but that would end up with 2 commits which seems less elegant. Might be nice if it checked for empty and then did nothing on empty (except maybe log a warning).

    - uses: EndBug/add-and-commit@v7
      with:
        message: Generate SVG images for PlantUML diagrams
        add: ${{ steps.puml-diff.outputs.changed-light }} ${{ steps.puml-diff.outputs.changed-dark }}
        remove: ${{ steps.puml-files.outputs.removed-light }} ${{ steps.puml-files.outputs.removed-dark }}

Run EndBug/add-and-commit@v7
  with:
    message: Generate SVG images for PlantUML diagrams
    add:  docs/domain-model/.svg/user-light.svg  docs/domain-model/.svg/user-dark.svg
    remove:  
    author_name: xenoterracide
    author_email: [e-mail]
    cwd: .
    pull_strategy: --no-rebase
    push: true
Running in /home/runner/work/iw-ppm-backend/iw-ppm-backend
Add input parsed as single string, running 1 git add command.
> Using 'xenoterracide <[e-mail]>' as author.
> Using "Generate SVG images for PlantUML diagrams" as commit message.
Internal logs
  > Staging files...
  > Adding files...
  Error: Error: fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths

[xenoterracide]

Oh, I got it tested last night finally. It seems to work now

On Sat, Apr 3, 2021, 9:00 AM Federico Grandi @.***> wrote:

The action will not stop if git commands fail because they don’t match any file, this is intended behavior. If you want the workflow run to fail in this situation you’ll have to either run a custom command or use an action like [this].( https://github.com/marketplace/actions/file-existence)

Please test @.*** as soon as you can, thank you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EndBug/add-and-commit/issues/154#issuecomment-812869263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABLDKMBU3YIVUJE6UQ3TLTG4NRRANCNFSM42BLE6IQ .

[EndBug]

Hi, thanks for the report! You’re right, you could do separate steps with checks, but it’s really counter-intuitive that an empty string causes the action to fail, also because the default value for remove is actually an empty string. The problem comes from the fact that that string technically isn’t empty, but it contains a space character ' '. I’ll solve this by trimming the add and remove strings, so that strings like that will become empty.