question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug fix: Revert or refactor evasive transforms

See original GitHub issue

We have master in an unreleasable state. We can fix it by either reverting https://github.com/endojs/endo/pull/608 (if we are satisfied with evaluator options as API for the evasive transforms) or by factoring the evasive transforms out of src/transforms.js and up to a new transforms.js that package.json already points to (but does not yet exist).

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:12 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
erightscommented, Mar 16, 2021

I have no objection to rolling forward.

@rekmarks I am curious what those other transforms are and why they’re needed?

1reaction
kriskowalcommented, Mar 16, 2021

So, assuming we roll forward instead of rolling back, to be releasable, we need to move some of the exports of src/transforms.js into a transforms.js (not src/*, which does not yet exist). There’s already a reference to that file in package.json. The top-level transforms.js should only export intentionally public API.

There are some internal methods in src/transforms.js that need to stay there because they are only useful internally.

Read more comments on GitHub >

github_iconTop Results From Across the Web

On the Relationship between Refactoring Actions and Bugs
ABSTRACT. Software refactoring aims at improving code quality while preserv- ing the system's external behavior.
Read more >
TSC refactor · Issue #1146 · sktime/sktime · GitHub
Hi @fkiraly, I have refactored BOSSEnsemble classifier, great if you could have a look at the below 3 points and share your feedback....
Read more >
Refactoring vs. Defactoring - Understand Legacy Code
When most developers talk about “refactoring the code”, they really mean “restructuring the code”. Rewriting it. Certainly to make it better and fix...
Read more >
Bug in 8.5 (build 3183): Undoing a refactoring (like "Rename ...
Undoing a refactoring performs Undo only in the file where the refactoring was initiated, but not in any of the other impacted files,...
Read more >
Patterns for Managing Source Code Branches - Martin Fowler
If merged in we must be careful that the head of the release branch exactly matches the head of mainline. One way to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found