Bug fix: Revert or refactor evasive transforms
See original GitHub issueWe have master
in an unreleasable state. We can fix it by either reverting https://github.com/endojs/endo/pull/608 (if we are satisfied with evaluator options as API for the evasive transforms) or by factoring the evasive transforms out of src/transforms.js
and up to a new transforms.js
that package.json
already points to (but does not yet exist).
Issue Analytics
- State:
- Created 3 years ago
- Comments:12 (12 by maintainers)
Top Results From Across the Web
On the Relationship between Refactoring Actions and Bugs
ABSTRACT. Software refactoring aims at improving code quality while preserv- ing the system's external behavior.
Read more >TSC refactor · Issue #1146 · sktime/sktime · GitHub
Hi @fkiraly, I have refactored BOSSEnsemble classifier, great if you could have a look at the below 3 points and share your feedback....
Read more >Refactoring vs. Defactoring - Understand Legacy Code
When most developers talk about “refactoring the code”, they really mean “restructuring the code”. Rewriting it. Certainly to make it better and fix...
Read more >Bug in 8.5 (build 3183): Undoing a refactoring (like "Rename ...
Undoing a refactoring performs Undo only in the file where the refactoring was initiated, but not in any of the other impacted files,...
Read more >Patterns for Managing Source Code Branches - Martin Fowler
If merged in we must be careful that the head of the release branch exactly matches the head of mainline. One way to...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I have no objection to rolling forward.
@rekmarks I am curious what those other transforms are and why they’re needed?
So, assuming we roll forward instead of rolling back, to be releasable, we need to move some of the exports of
src/transforms.js
into atransforms.js
(notsrc/*
, which does not yet exist). There’s already a reference to that file inpackage.json
. The top-leveltransforms.js
should only export intentionally public API.There are some internal methods in
src/transforms.js
that need to stay there because they are only useful internally.