Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
does removeProperties visit prototypes?
See original GitHub issue[edit 2020-09-15 @kriskowal]
@erights volunteers to verify that we have addressed this.
@dtribble and I were looking at removeProperties.js, and we noticed that the clean() function does a recursive traversal of named properties (Object.getOwnPropertyNames) but is not traversing the Object.getPrototypeOf links. It uses getPrototypeOf to implement the * permission value, but that only appears in getPermit() and not in the traversal code.
As a result, we won’t be applying the whitelist to any of the prototypes, unless they’re reachable by other named pathways like Number.prototype. Is this enough? Are there any primordials that are only reachable by following an Object.getPrototypeOf() from some named object?
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
not mn-1
@erights needs to check, this is probably just a small amount of work, if it is not already doing what it should.