question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor harden such that it follows prototype chains

See original GitHub issue

What’s the purpose / justification of this test?

https://github.com/Agoric/harden/blob/e29849c18e0cfbbd41db1e8765954d4bc51d5e4a/test/test.js#L14

This is the only test that fails when I implement harden using deep freezing from the moddable SDK:

export default function harden(root) {
  return Object.freeze(root, true);
}

https://github.com/dckc/harden/blob/deepFreeze-xs/src/deepFreeze.js

cc @erights @warner @phoddie

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:16 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
kriskowalcommented, Sep 15, 2020

We intend to refactor harden such that this issue would go away. We would transitively freeze up the prototype chain.

0reactions
erightscommented, Dec 29, 2020

Fixed by #541

Read more comments on GitHub >

github_iconTop Results From Across the Web

Prototype - Refactoring.Guru
Prototype is a creational design pattern that lets you copy existing objects without making your code dependent on their classes.
Read more >
swingset JS-engine heap snapshots · Issue #511 · Agoric/agoric-sdk ...
XS currently reloads the snapshot with the help of a C compiler, so we'd need to ... Refactor harden such that it follows...
Read more >
Realms and Evaluator Shim Security - Agoric
The Function constructor reachable through the prototype chain of all other primordials will throw an exception, rather than reveal the platform ...
Read more >
TypeScript : Object Equality Comparison (Object Equals Object)
If not, don't worry. If so, then you need to harden your equality check to deal with it. Hope that helps; good luck!...
Read more >
Eratosthenes: Radically Refactoring the Web - Microsoft
Such an ambitious refactoring of the web interface is ... DPI toolchains, and runtime overhead. ... In contrast, our pico-datacenter follows the commu-....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found