Some popular packages don't work correctly under SES
See original GitHub issueSome popular packages don’t work correctly under SES
This is primarily seems to be caused by setting properties that appear in the frozen primordials like x.toString = y
I’ll record them here
regenerator-runtime
16,886,889 downloads / week
v0.13.3
requires non-strict mode? https://github.com/facebook/regenerator/blob/6e9e8d7747c2ab49927bdd9dd6261753181faec1/packages/regenerator-runtime/runtime.js#L713-L726v0.11.1
: deriving a global fromreturn this
https://github.com/Agoric/SES/issues/140 https://github.com/facebook/regenerator/blob/610e60882404480d5dec4fdbeaa56e1773dbfe37/packages/regenerator-runtime/runtime-module.js#L10
symbol-observable
6,602,849 downloads / week
- tries to mutate
Symbol
https://github.com/benlesh/symbol-observable/blob/e56e765476fd96dcb430fd44d936bc543d4d97ba/es/ponyfill.js#L9-L10
deep-equal
6,532,310 downloads / week
1.0.1
accidentally assigns “shim” toObject.keys
https://npmfs.com/package/deep-equal/1.0.1/lib/keys.js
underscore
6,453,579 downloads / week
- overriding Object.prototype properties https://github.com/jashkenas/underscore/blob/36eef3c118041ae6386b6bba2b48b099e57ca0e5/underscore.js#L1676
- overriding Function.prototype properties https://github.com/jashkenas/underscore/blob/36eef3c118041ae6386b6bba2b48b099e57ca0e5/underscore.js#L772
crypto-js
909,612 downloads/week
- overriding
toString
via computed set (this[propertyName] = properties[propertyName]
) https://github.com/brix/crypto-js/blob/8e6d15bf2e26d6ff0af5277df2604ca12b60a718/src/core.js#L132 Setting via computed assign previously defeated my babel-plugin workaround, but I added support for it
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (5 by maintainers)
Top Results From Across the Web
Great Pacific Garbage Patch | National Geographic Society
The Great Pacific Garbage Patch is a collection of marine debris in the North Pacific Ocean. Also known as the Pacific trash vortex, ......
Read more >Shipping Damage: How Ecommerce Companies Can Prevent It
The 6 most common causes of shipping damages in ecommerce · 1. Too much empty space in the package · 2. Not enough...
Read more >Top 8 Ship Tracking Websites To Find Your Ship Accurately
Marine-Traffic, one of the most famous and widely used online ship tracking systems, offers ships' real-time data and advanced search ...
Read more >Garbage Patches | OR&R's Marine Debris Program
Learn more about what garbage patches are, their impacts on the ocean, and what we can do about them.
Read more >Royal Caribbean Blog - Unofficial blog about Royal ...
Let's take an in-depth look at what it means to tender on a cruise ship, which ports require tendering, and if you should...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@michaelfig I need to update this list, many can be removed now
I published deep-equal v1.1.0 btw so i assume it can be removed from the list?