question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Branches with forward-slashes in the branch name break Gitako during navigation

See original GitHub issue

Steps to reproduce:

  1. There is a branch called 6737-trailing-space/auth-fix in this repo: https://github.com/aws-amplify/amplify-js

  2. On first load, the branch is set correctly: Screenshot 2022-06-29 at 1 00 35 PM

  3. If you navigate to a file by clicking on it in Gitako, the branch name is set incorrectly and it breaks: Screenshot 2022-06-29 at 1 01 53 PM

  4. Reloading the page fixes it.

Here’s the URL to try yourself: https://github.com/aws-amplify/amplify-js/tree/6737-trailing-space/auth-fix

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
EnixCodacommented, Jul 27, 2022

@kidonng Not at all, I am always grateful about your help. 😄

1reaction
kidonngcommented, Jul 27, 2022

No hard feelings! I may have misunderstood your comment because the difference does seem clear to me 😥

Now that I’m taking a closer look, the code I’m referencing is a little bit off, it should be this disambiguateReference function which tells the branch and file path apart, which in turn depends on getCurrentCommittish.

Perhaps Refined GitHub also depends on DOM elements to achieve that?

Indeed. I see you have figured it out by yourself.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Backstage doesn't recognize branches that contain forward ...
This library has a bug that causes it to incorrectly parse URLs that point to branches with forward slashes in them.
Read more >
Using the slash character in Git branch name - Stack Overflow
When you have a branch with slashes in it, it gets stored as a directory hierarchy ... The reason: Branches are stored in...
Read more >
Web IDE - Issue with branch names with slashes - GitLab
Summary. Hi,. Just to let you know that, on GitLab v.10.8.1, while browsing through the Web IDE, there's an issue when the branch...
Read more >
Git branch names support forward slashes
I've been using git for years now and I only learned this today – git branch names support forward slashes! How awesome is...
Read more >
Source view URL of branch name with slashes broken ... - Jira
BCLOUD-20964 - Support forward slash in branch name in url ... opens a browser to your bitbucket/github/gitlab to view whatever branch you have...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found