Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Cannot copy code from github pr file changed tab

See original GitHub issue

After installing this extension. I cannot copy code from github pr File changed tab.

CMD+C or context menu.

Gitako v2.7.1

Recording: https://p-myf5wv.b3.n0.cdn.getcloudapp.com/items/wbu9qQee/8489acf7-cdfe-4456-9b63-357071cec5e6.gif

Issue Analytics

State:
Created 3 years ago
Comments:8 (5 by maintainers)

Top GitHub Comments

3reactions

EnixCodacommented, Mar 8, 2021

🤯

The issue is fixed after removing an unused CSS class in a0f6ad33987aefd24dd7df5e41894f97aed789c7 , .invisible, whose functionality is setting the element’s visibility to hidden. The class was created since the very first few commits of Gitako at about 3 years ago and soon deprecated. I forgot to removed it in time so that it was kept until today.

When copy event is triggered inside the diff panels, GitHub’s script will append a new table element into DOM to sanitize the text to be copied. By coincidence, the element is of the exact same class name mentioned above, invisible.

Thus the table element is not actually rendered, which is Chrome/Chromium’s way of handling elements of visibility: hidden I guess, and the copy action fails.

What a bug.

1reaction

EnixCodacommented, Mar 10, 2021

The patch has been released in v2.7.2.

cc @kbsali