Integer and decimal widgets disappear after switching language

Describe the bug

For a form with two languages, integer and decimal questions appear initially, but after switching to the second language, they disappear. They do not return after switching back to the first language.

I’ve seen #495, #496, etc., but this problem happens even when config.json either

• contains no widgets override, or
• contains an array of widgets that explicitly includes integer and decimal.

The problem does not happen on https://enketo.getodk.org/, but that instance reports to be running version: 5.0.0-4-g67bf890. I couldn’t find that commit in this repository. If there’s a hotfix somewhere, I’d love to use it 😃

To Reproduce

Use this minimal XLSForm: numbers-missing-after-language-switch.xlsx

type	name	label::OK	label::NG
integer	int_q	OK int	NG int
decimal	dec_q	OK dec	NG dec
text	txt_q	OK txt	NG txt

1. Check out tag 5.0.0 from this repository
2. Create a minimal config.json, e.g.

   {
       "port": "8999",
       "encryption key": "insecure-enketo-dev",
       "linked form and data server": {
           "api key": "insecure-enketo-dev",
           "server url": ""
       },
       "redis": {
           "cache": {
               "host": "10.6.6.1",
               "password": "insecure-redis-dev",
               "port": "60667"
           },
           "main": {
               "host": "10.6.6.1",
               "password": "insecure-redis-dev",
               "port": "60667"
           }
       }
   }
   

3. npm run start etc.
4. Use XLSForm Online to generate the XForm from numbers-missing-after-language-switch.xlsx (above)
   1. Click “Preview in browser” and see that it works properly
   2. Grab the path and query string, e.g. preview?form=https%3A//xlsform.getodk.org/downloads/xbeexfwc/numbers-missing-after-language-switch.xml
5. Use that path and query string with local Enketo 5.0.0, e.g. http://localhost:8999/preview?form=https%3A//xlsform.getodk.org/downloads/xbeexfwc/numbers-missing-after-language-switch.xml
6. See that things look good initially:
7. Switch to “NG” language
8. See that integer and decimal questions disappear while the text question remains:
9. Switch back to “OK” language and see that the questions are still gone.

Browser and OS (please complete the following information):

• OS: Linux
• Browser: Firefox and Chrome

[lognaturel]

One of the changes made to reduce the risk of data loss due to invalid numeric input is to set the lang attribute on numeric controls. This is broadly recommended (eg https://www.ctrl.blog/entry/html5-input-number-localization.html). However, form translations are done by hiding every element with lang attributes that don’t also have an active attribute. We’re trying to fix this current issue in a way that makes sense and allows broader use of the lang attribute which is good for accessibility.

[lognaturel]

overall participation has been limited to a few power users

Yes, that’s what we’re finding too. In general we are not very satisfied with how we do (or don’t) get feedback about Enketo as part of the release process. Ideas for improvement are welcome.

When you find regressions, getting a feel for how severe you find it, whether it’s in production, and how it has been found would be helpful. We try to prioritize regressions but it can be pretty disruptive so if you consider it minor or you’re not deploying yet anyway that would be very helpful to know. It can also take us some time to feel like we have a safe and thoughtful fix when we run into unexpected interactions like we did here.