When an encrypted form has a space in its formID, submission to data server fails with 404

v2.7.3

Describe the bug When an encrypted form has a space in its formID, submission to data server fails with 404. See Central issue and original ODK forum report from LSHTM. We suspect this would affect any formID that needs to be URL-encoded.

To Reproduce

1. Create a form definition with a space in its formID and an encryption key on a data server
2. Successfully create a link for and open the form in Enketo
3. Fill out the form and try to submit it
4. See Submission service on data server not found. (404)

Expected behavior Forms with any formID can be encrypted.

Suspicious: https://github.com/enketo/enketo-express/blob/3f353ea44934045e185db71e26ec331146ec2610/public/js/src/module/controller-webform.js#L268

My next step would be to try this locally to see what is actually being sent to the data server. I can’t find a way to do that on a production server.

[lognaturel]

To be clear, this /only/ affects encrypted forms. FormIDs with spaces work fine generally. That’s why that line which relates only to encrypted forms seems like a very likely culprit.

[MartijnR]

Thanks. Possible link with https://github.com/enketo/enketo-express/issues/35 (but probably not).