Best way to rename field?

I have a property named IPAddress, and its converted to iPAddress what is the best way to rename it?

Currently i do the following:

schema.Type<Device>().RemoveField(x => x.IPAddress);
schema.Type<Device>().AddField("ipAddress", x => x.IPAddress, "");

The downside i have found is that i loose all comments that i have applied using the Description attribute. (Same thing happens with MACAddress)

[AnderssonPeter]

@lukemurray the AddMutationFrom does not have a fieldNamer argument so the input arguments there still get incorrectly renamed.

How about storing the one that gets sent into FromObject that way we don’t have to send a new one with every AddType.

"kind": "OBJECT",
"name": "Mutation",
"description": "The mutation type, represents all updates we can make to our data",
"fields": [{
	"name": "addDevice",
	"description": null,
	"args": [{
			"name": "mACAddress", <---
			"description": null,
			"type": {
				"kind": "NON_NULL",
				"name": null,
				"ofType": {
					"kind": "SCALAR",
					"name": "String",
					"ofType": null
				}
			},
			"defaultValue": null
		}, {
			"name": "iPAddress", <---
			"description": null,
			"type": {
				"kind": "NON_NULL",
				"name": null,
				"ofType": {
					"kind": "SCALAR",
					"name": "String",
					"ofType": null
				}
			},
			"defaultValue": null
		}, {

Or if you want a function that handles this correctly (I have tested all combinations i can think of but i might have missed something):

private static string FieldNamer(MemberInfo memberInfo)
{
    var name = memberInfo.Name;
    for (var i = 0; i < name.Length; i++)
    {
        if (!char.IsUpper(name[i]))
        {
            if (i == 0)
            {
                return name;
            }
            if (i == 1)
            {
                return name.Substring(0, i).ToLower() + name.Substring(i);
            }
            else
            {
                return name.Substring(0, i - 1).ToLower() + name.Substring(i - 1);
            }
        }
    }
    return name.ToLower();
}

[lukemurray]

Whoops thanks.

---

From: Peter [e-mail] Sent: Friday, June 5, 2020 1:57:20 AM To: lukemurray/EntityGraphQL [e-mail] Cc: Luke Murray [e-mail]; Comment [e-mail] Subject: Re: [lukemurray/EntityGraphQL] Best way to rename field? (#46)

I think i found a bug https://github.com/lukemurray/EntityGraphQL/blob/74f8d576870eb4cfc31a3a2fc4607bdf058eb513/src/EntityGraphQL/Schema/SchemaBuilder.cs#L46 the fieldRenamer is never passed to the other method.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/lukemurray/EntityGraphQL/issues/46#issuecomment-638947686, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABGHUOYT3GO5GCYU3BM2HTRU676BANCNFSM4M5ZZYAQ.