Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Unable to reverse engineer stored procedure using TVP parameter with NVARCHAR(MAX) column

See original GitHub issue

Unable to reverse engineer stored procedure using TVP as parameter because the TVP includes columns with NVARCHAR(MAX).

Error Output:

Unable to get result set shape for PROCEDURE 'dbo.MyProcedure'
System.Data.DuplicateNameException: A column named 'ColumnName' already belongs to this DataTable.
   at System.Data.DataColumnCollection.RegisterColumnName(String name, DataColumn column)
   at System.Data.DataColumnCollection.BaseAdd(DataColumn column)
   at System.Data.DataColumnCollection.AddAt(Int32 index, DataColumn column)
   at RevEng.Core.Procedures.SqlServerStoredProcedureModelFactory.GetDataTableFromSchema(ModuleParameter parameter, SqlConnection connection) in C:\Code\EFCorePowerTools\src\GUI\RevEng.Core\Procedures\SqlServerStoredProcedureModelFactory.cs:line 155
   at RevEng.Core.Procedures.SqlServerStoredProcedureModelFactory.GetAllResultSets(SqlConnection connection, Routine module, Boolean singleResult) in C:\Code\EFCorePowerTools\src\GUI\RevEng.Core\Procedures\SqlServerStoredProcedureModelFactory.cs:line 83
   at RevEng.Core.Procedures.SqlServerStoredProcedureModelFactory.GetResultElementLists(SqlConnection connection, Routine module, Boolean multipleResults, Boolean useLegacyResultSetDiscovery) in C:\Code\EFCorePowerTools\src\GUI\RevEng.Core\Procedures\SqlServerStoredProcedureModelFactory.cs:line 62
   at RevEng.Core.Procedures.SqlServerRoutineModelFactory.GetRoutines(String connectionString, ModuleModelFactoryOptions options) in C:\Code\EFCorePowerTools\src\GUI\RevEng.Core\Routines\SqlServerRoutineModelFactory.cs:line 25

I noticed that recent changes to SqlServerStoredProcedureModelFactory.GetDataTableFromSchema don’t compensate for the sysname datatypes with the same name returned alongside NVARCHAR(MAX). Maybe we filter those out?

EF Core version in use: EF Core 6

Is Handlebars used: no

EF Core Power Tools version: 2.5.963

Database engine: SQL Server, Azure SQL

Visual Studio version: Visual Studio 2022 - Preview 4