Unexpected Reverse Engineering for Bit Field

Describe what is not working as expected.

Given the SQL Server table

USE [CuratedPhase1]

SET ANSI_NULLS ON

SET QUOTED_IDENTIFIER ON

CREATE TABLE [dbo].[FanProductPerformanceCorrections](
	[FanProductId] [uniqueidentifier] NOT NULL,
	[FanPerformanceCorrectionId] [uniqueidentifier] NOT NULL,
	[CorrectionOrder] [smallint] NOT NULL,
	[MustHave] [bit] NOT NULL,
	[ApplyCorrection] [bit] NOT NULL,
 CONSTRAINT [PK_FanProductPerformanceCorrections] PRIMARY KEY CLUSTERED 
(
	[FanProductId] ASC,
	[FanPerformanceCorrectionId] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON)
)


GO

Expect the following reverse engineering result

    public partial class FanProductPerformanceCorrection
    {
        public FanProductPerformanceCorrection()
        {
            FanProductPerformanceCorrectionVariables = new HashSet<FanProductPerformanceCorrectionVariable>();
        }

        public Guid FanProductId { get; set; }
        public Guid FanPerformanceCorrectionId { get; set; }
        public short CorrectionOrder { get; set; }
        public bool MustHave { get; set; }
        public bool ApplyCorrection { get; set; }

        public virtual FanPerformanceCorrection FanPerformanceCorrection { get; set; }
        public virtual FanProduct FanProduct { get; set; }
        public virtual ICollection<FanProductPerformanceCorrectionVariable> FanProductPerformanceCorrectionVariables { get; set; }
    }

but getting

 public partial class FanProductPerformanceCorrection
    {
        public FanProductPerformanceCorrection()
        {
            FanProductPerformanceCorrectionVariables = new HashSet<FanProductPerformanceCorrectionVariable>();
        }

        public Guid FanProductId { get; set; }
        public Guid FanPerformanceCorrectionId { get; set; }
        public short CorrectionOrder { get; set; }
        public bool MustHave { get; set; }
        public bool? ApplyCorrection { get; set; }

        public virtual FanPerformanceCorrection FanPerformanceCorrection { get; set; }
        public virtual FanProduct FanProduct { get; set; }
        public virtual ICollection<FanProductPerformanceCorrectionVariable> FanProductPerformanceCorrectionVariables { get; set; }
    }

Note that APPLYCORRECTION in the second C# example is marked as nullable (bool?).

This behavior has been present for at least the last six months, and is not specific to recent builds. (we’ve been fixing it by hand)

[bricelam]

This is expected. EF Core uses the CLR default value to determine if it should use the SQL default. If it wasn’t nullable you could never save false:

With a bool property:

.NET	SQL
false	1 (via DEFAULT)
true	1

With a bool? property:

.NET	SQL
null	1 (via DEFAULT)
false	0
true	1

[jostapotcf]

A new advanced option is now available to work around this issue.

Hey Erik. Thanks for this!

We’re going to be making a refactoring pass on our database here in the next few weeks (major version increment). I’ve added a devops note to check this. If it’s helpful, I’ll respond here with confirmation.