Discussion: Add future debit charges for the bank accounts

The goal

Be able to see my current balances (already possible) and the future charges I should expect from my credit cards according to their next charging date. That will help not just reading the history of the charges, but also getting the current status in an easy-to-use way.

What exists on the bank website?

In the credit card section of each bank website, you have all of your credit cards, their charge date, and the accumulated charge amount.

By default, only the bank-issued credit cards appear, but anyone can request to also see the accumulated charges from other issuers (cal, max, isracard). Due to that, in order to see the charges on the next charge date - there is no real need to fetch that data form cal/max/isracard because the banks are taking care of that.

What exists today in this repo?

In his PR, https://github.com/eshaham/israeli-bank-scrapers/pull/656, @LiranBri added it for Cal - futureDebits :

export interface ScaperScrapingResult {
  success: boolean;
  accounts?: TransactionsAccount[];
  futureDebits?: FutureDebit[];
  errorType?: ScraperErrorTypes;
  errorMessage?: string; // only on success=false
}

export interface FutureDebit {
  amount: number;
  amountCurrency: string;
  chargeDate?: string;
  bankAccountNumber?: string;
}

By the way, this is not documented in the readme file at the moment.

This was a very cool addition that is highly needed IMO.

What do I think we should do?

After I talked offline with @LiranBri , and like I said before, IMO this information should really just be in the bank accounts and not the other vendors. More than that, IMO this data should show the charges for each credit card separately so it will be more generic. At the moment it’s grouped by the bank account number - so again it’s all coming back to the bank account.

So here is what I’m suggesting:

1. Remove the futureDebits object added by @LiranBri + remove this code from the Cal scraper (it won’t be a breaking change as it’s undocumented anyway…)
2. Replace it under the standard account: TransactionsAccount object:

export interface TransactionsAccount {
    accountNumber: string;
    balance?: number;
    txns: Transaction[];
    futureCharges?: FutureCharge[];
}

export interface FutureCharge {
  amount: number;
  amountCurrency: string;
  chargeDate: string;
  cardLastFourDigits: string;
  issuesByTheBank: boolean;
  issuer: string; ("מקס, ישראכארט, כאל")
}

IMO that will introduce a more generic way to get ALL the future credit card chargers which will be more aligned with the way the current code works and separation by card.

What can I do?

I can go ahead and do that for the Hapoalim bank, and so create the infrastructure for this to be implemented on other bank scrapers. But before I do that, I would like to get @LiranBri and @erikash opinions so I won’t develop it for nothing 😃 WDYT?

[eshaham]

Love the discussion here and where this is going 💪

[erikash]

Go ahead!

On Mon, Jul 11, 2022 at 6:17 PM Liran Brimer @.***> wrote:

Go ahead 💪

— Reply to this email directly, view it on GitHub https://github.com/eshaham/israeli-bank-scrapers/issues/707#issuecomment-1180540911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCIPMBOOEFUKJWFQODJ5LVTQ3HBANCNFSM53BVA4MQ . You are receiving this because you were mentioned.Message ID: @.***>