else statement returns still emits a return a value error

The error each then() should return a value is reported even though the .then always returns a promise in the code below.

Apparently the logic for following return values can’t evaluate an else clause

    return oracle.getPrices(c)
    .then(function(p) {
        if (p.price != 0) {
            return p.price.toNumber() / 1e6;
        } else {
            // XXX unavoidable race
            return 200;
        }
    });  

[xjamundx]

right because I personally prefer the no-else-return rule, so in my case I’d still do the return 200 at the root level of the function.

Yeah totally valid bug though, solution is tricky to enforce properly.

We could check that there’s any return inside of a then function. For example:

.then(function(p) {
    if (p < 10) {
        return p * 1000;
    }
})

But then it obviously misses cases like this where the root of the function isn’t covered, but to some extent that is covered by consistent-return.

What do you think? Would you be able to try to make the code change?

[xjamundx]

ahh thanks for the note @scottnonnenberg I’ll try to look at this…in the meantime you may be abe to do something like this:

var dates
try { dates = parseWithDates(text) }
catch (e) { data = undefined }
return [response, dates]