Add ignoreDefaultParamAssign option to space-infix-ops

What rule do you want to change? space-infix-ops

Does this change cause the rule to produce more or fewer warnings? Fewer!

How will the change be implemented? (New option, new default behavior, etc.)? A new option called ignoreDefaultParamAssign that will relax the rule when it comes to assigning defaults for function parameters.

Please provide some example code that this change will affect:

// Currently not allowed:
function fun(value, multiplier=1, callback, setting=false) {
    value = 3+4;
    ....
}

// Currently allowed:
function fun(value, multiplier = 1, callback, setting = false) {
    value = 3 + 4;
    ....
}

// Not allowed with proposed option:
function fun(value, multiplier=1, callback, setting=false) {
    value = 3+4;
    ....
}

// Allowed with proposed option:
function fun(value, multiplier=1, callback, setting=false) {
    value = 3 + 4;
    ....
}

What does the rule currently do for this code? A dev team could argue that assigning a single primitive value as a default for a function parameter would be more readable in a list of other parameters, because it couples the name and value together whilst separating it from the other variables by spaces.

[kasvtv]

Glad you’re on board on this one!

And yes, we should camelCase the name of course! I happened to forget that the rule names with dashes and the options are camelCase. Edited my issue.

[platinumazure]

Sounds good to me. I know this is similar to the equivalent style guidelines for Python, so there’s a decent chance people would use this option.

I think we could bikeshed on the option name a bit- for example, it could be camelcase (e.g., ignoreDefaultParamAssign) to save some typing in some config file formats. But putting that aside for the moment, I’m 👍 to this enhancement.