Add option to disable class-methods-use-this on inheritance

What rule do you want to change? class-methods-use-this

Does this change cause the rule to produce more or fewer warnings? Fewer.

How will the change be implemented? (New option, new default behavior, etc.)? New option: disableOnInheritance.

Please provide some example code that this change will affect:

class ConfigService extends ConfigManager {
  provideConfigSpec() {
    return {
      ENV_VAR: 'test';
    };
  }
}

What does the rule currently do for this code? It throws the error because of the base class method provideConfigSpec that doesn’t use `this.

What will the rule do after it’s changed? Will disable the error when inheriting.

Are you willing to submit a pull request to implement this change? With some guidance, yes.

[mdjermanovic]

Thanks for the info!

The enhancement is open for evaluation, it needs a champion and 3 other 👍 from the team to be accepted.

The option seems useful to avoid a long list in exceptMethods, but on the other hand looks like it would disable too much, i.e. limit the rule to check just base classes.

[eslint-deprecated[bot]]

Unfortunately, it looks like there wasn’t enough interest from the team or community to implement this change. While we wish we’d be able to accommodate everyone’s requests, we do need to prioritize. We’ve found that issues failing to reach accepted status after 21 days tend to never be accepted, and as such, we close those issues. This doesn’t mean the idea isn’t interesting or useful, just that it’s not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.