array-callback-return incorrectly assumes an array

Tell us about your environment

• ESLint Version: v4.0.0-alpha.0
• Node Version: v7.6.0
• npm Version: v4.1.2

What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration: https://github.com/thelounge/lounge/blob/8c987e7a2812dcc9f01df639df3d7c68339ab742/.eslintrc.yml

Reduced test case:

require("event-stream").map(() => {});

var es = require("event-stream");
es.map(() => {});

This does not report an error on v3.19.0, probably due to array-callback-return not being in the eslint:recommended.

[not-an-aardvark]

Oh I see, here’s an example from the docs. Thanks for explaining.

So it has a method called map, but it doesn’t expect a value to be returned from the map function (it passes a callback instead).

event-stream is a very popular library, so I think we should probably remove array-callback-return from eslint:recommended. We removed no-template-curly-in-string in https://github.com/eslint/eslint/issues/8236 for much less.

[btmills]

The TSC decided to remove array-callback-return from eslint:recommended in the 2017-04-13 meeting.