Assigning to free variables in the node environment should not trigger no-global-assign errors.

Tell us about your environment

• ESLint Version: 4.9.0
• Node Version: 6.11.4
• npm Version: 3.10.10

What parser (default, Babel-ESLint, etc.) are you using? Default.

Please show your full configuration:

module.exports = {
  env: {
    node: true,
  },
  rules: {
    'no-global-assign': ['error'],
  },
};

What did you do? Please include the actual source code causing the issue.

require = function () {};

What did you expect to happen? require is a free variable in Node, it’s not a global variable. (Try evaluating 'require' in global in a JavaScript file in Node. It evaluates to false.) Therefore, no error should be reported.

What actually happened? Please include the actual, raw output from ESLint.

ESLint reports the following error:

1:1  error  Read-only global 'require' should not be modified  no-global-assign

[jacksonrayhamilton]

Fair enough, especially considering CommonJS always requires some preprocessing. ESLint can’t possibly anticipate the infinitely many ways in which legitimate JS code could be preprocessed and how that could thus affect the semantics on the code it’s analyzing. CommonJS may be popular, but the “magic” involved doesn’t lend itself well to generic static analysis.

[platinumazure]

@jacksonrayhamilton I think this might be a case where you should use eslint-disable comments. We can’t cover every corner case and on rare occasions, a rule just might report something that is either contrary to more important requirements in your codebase, or outright incorrect.

I don’t think we can make a change here without having ESLint know too much about CommonJS scoping rules, which we don’t really want to do (for the purpose of trying to keep the library runtime-agnostic).