brace-style "allowSingleLine" should differentiate between if/else and function statements.

What version of ESLint are you using?

v2.2.0

What parser (default, Babel-ESLint, etc.) are you using?

Default.

Please show your full configuration:

"brace-style": [2, "1tbs", { "allowSingleLine": true }]

What did you do? Please include the actual source code causing the issue.

I have two snippets that eslint is (correctly) reporting. However, I’d like to disable half of the violations.

good, please continue flagging as an error

if (foo) { doFoo(); } else { doOther(); }

please allow me to disable errors for these statements

var o = { action: function () { doSomething(); } };

What did you expect to happen?

I expected "allowSingleLine" to accept an object to expose more granularity in my config.

"brace-style": [2, "1tbs", { "allowSingleLine": { "ifStatements": false, "functions": true } }]

What actually happened? Please include the actual, raw output from ESLint.

I’m seeing the usual errors being reported. Nothing out of the ordinary.

error  Statement inside of curly braces should be on next line   brace-style

[alberto]

Thanks for your interest in improving eslint. Unfortunately, it looks like consensus couldn’t be reached on this issue and so I’m closing it. While we wish we’d be able to accommodate everyone’s requests, we do need to prioritize. We’ve found that issues failing to reach consensus after 21 days tend never to reach consensus, and as such, we close those issues. This doesn’t mean the idea isn’t interesting, just that it’s not something the team can commit to.

As a reminder, you can still create a custom rule for your use use.

[Droogans]

Would // eslint-disable-line brace-style work on a case-by-case basis?

I’d much rather revert all one-liner functions to multi-line to avoid that issue entirely. I would go mad trying to keep an entire team’s worth of contributions using both single line functions and this comment above them all!