Bug: no-useless-return triggers wrongly in switch

Environment

Node version: v16.15.0 npm version: v8.11.0 Local ESLint version: v8.17.0
Global ESLint version: Not found
Operating System: win32 10.0.19043

What parser are you using?

@babel/eslint-parser

What did you do?

Configuration

'no-useless-return': ['error'],

function doot(blah) {
  switch (blah) {
    case something:
      return;
    case somethingElse:
      doSomethingReal();
      break;
  }
}

What did you expect to happen?

The return statement to be kept.

What actually happened?

Return is removed, making the case bleed over to the other one.

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[mdjermanovic]

I agree. In the example from https://github.com/eslint/eslint/issues/16055#issuecomment-1166409950, the no-useless-return rule works as intended because it reports a return; statement that has no effect on the runtime behavior.

[snitin315]

Alright, I’m guessing it was only issue when writing up the structure before any code, as removing the function call makes it trigger as reported, which I guess technically is right for the error?

Yes. That seems to be the intended behavior to me.