callback-return not working for calls immediately preceding returns

Tell us about your environment

Node version: v10.16.0 npm version: v6.13.7 Local ESLint version: v6.8.0 (Currently used) Global ESLint version: Not found

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

1581359005.zip

Configuration

module.exports = {
    "extends": "eslint:all",
    "env": {
        "es6": true
    }
};

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

index_1.js:

(() => {
    "use strict";

    const object = {
        "test": (callback) => {
            if (callback) {
                callback();
            }
        }
    };

    object.test2 = 42;
})();

index_2.js:

(() => {
    "use strict";

    const object = {
        "test": (callback) => {
            if (callback) {
                callback();

                return;
            }
        }
    };

    object.test2 = 42;
})();

./node_modules/.bin/eslint index_1.js index_2.js

What did you expect to happen?

Only report error for index_1.js file.

What actually happened? Please include the actual, raw output from ESLint.

/Users/revolt/1581359005/index_1.js
  11:17  error  Expected return with your callback function  callback-return

/Users/revolt/1581359005/index_2.js
  13:17  error  Unnecessary return statement  no-useless-return

✖ 2 problems (2 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Are you willing to submit a pull request to fix this bug?

Maybe.

[G-Rath]

@kaicataldo I’ve created #13064 - apologises for the title; it’s been a long day and couldn’t find of a more concise way to expression the problem (since its not actually only assignments).

[kaicataldo]

Making a new issue would be great. We’ve seen that discussions on closed/stale issues tend to not get much discussion.