Change no-magic-numbers to support default argument values

What rule do you want to change? no-magic-numbers Does this change cause the rule to produce more or fewer warnings? fewer How will the change be implemented? (New option, new default behavior, etc.)? new default behavior, or new option if needed, but I don’t believe it would be. Please provide some example code that this change will affect:

function format(ms, precision = 2) {
  // do stuff
}

What does the rule currently do for this code? It considers the 2 a magic number, even though it has an explicit meaning. What will the rule do after it’s changed? It would treat this code as valid.

[michaelficarra]

This is still a magic number. The program should be written like

const IEEE_RECOMMENDED_PRECISION = 2;
const LJNEON_PREFERRED_PRECISION = 3;
const COMPANY_STANDARD_PRECISION = 4;

function format(ms, precision = LJNEON_PREFERRED_PRECISION) {
  // do stuff
}

to give context-free meaning to 2 instead of just the format-context sensitive meaning precision.

I continue to believe we should not add options that should be avoided in order to follow the either the spirit of or the initial justification for the rule.

[platinumazure]

I’d slightly prefer that this be an option, so that users can choose either way. Otherwise 👍 from me.