question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change Request: Add docker support

See original GitHub issue

ESLint version

all

What problem do you want to solve?

ESLint currently does not have official docker support. While it is certainly possible to build a custom container, for CI pipelines that introduces unnecessary overhead. Also it makes it impossible to do a ‘quick-one-off’. e.g. while it is possible to do eslint file.js on a local system, if a user does not want the overhead of installing all the dependencies (npm etc) and would much prefer to use a docker container, they currently have to rely 3rd party containers.

CI systems fall into the same category, where building custom images or using 3rd party images are fine, they make it harder then it should be.

What do you think is the correct solution?

From usability AND security point of view, offering an official ESLint Docker container is by far the most ideal solution.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

While in terms of process, #15430 has been already closed, I believe it checks all the marks.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
btmillscommented, Dec 31, 2021

As far as I’m aware, shellcheck, shfmt, and hadolint don’t have plugins. Is that correct? So many ESLint users include plugins, which removes the big benefit of having a pre-build Docker image. Users would still need to run an install step inside the container before running eslint. They’d have to either maintain a separate dependency manifest just for ESLint and its plugins or accept redundantly installing CI-related dependencies twice - once in the ESLint container and once to run other CI tasks.

0reactions
oliv3rcommented, Jan 1, 2022

Yeah, sure, no problem. Sad that you don’t want to support all your users (especially from a security PoV) and just prefer people roll their own 😦

Such is life!

Read more comments on GitHub >

github_iconTop Results From Across the Web

docker service update - Docker Documentation
Update a service · Perform a rolling restart with no parameter changes · Add or remove mounts · Add or remove...
Read more >
How do you change Docker OS Support for a .Net Core Web ...
Select Docker Support from the Project menu. · Right-click the project in Solution Explorer and select Add > Docker Support.
Read more >
Visual Studio Container Tools with ASP.NET Core
Select Docker Support from the Project menu. Right-click the project in Solution Explorer and select Add > Docker Support. The Visual Studio ...
Read more >
GitLab Docker images
You can pre-configure the GitLab Docker image by adding the environment variable GITLAB_OMNIBUS_CONFIG to Docker run command. This variable can contain any ...
Read more >
Developing inside a Container - Visual Studio Code
Add your user to the docker group by using a terminal to run: sudo usermod -aG docker $USER. Sign out and back in...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found