Clarification of `sort-imports` rule with destructuring imports

ESLint version 2.1.0.

I think any destructuring import should be grouped together when using sort-imports rule.

Right now, this is valid with default options:

import { Router, browserHistory as history } from 'react-router'
import React from 'react'
import { render } from 'react-dom'
import routes from './routes'

Where as, it is easier to read if everything that started with a { were grouped together, like so:

import { Router, browserHistory as history } from 'react-router'
import { render } from 'react-dom'
import React from 'react'
import routes from './routes'

While technically, it is a single import, I find it looks out of place. So, I am not sure if this would be considered a bug, or a feature request?

Sorry about the title, not sure how to describe this well. Feel free to adjust the title.

[wyze]

I went ahead and implemented this in my own plugin as I was uncertain if it would get merged into core. I just wanted to share the diff, which isn’t too bad. I am not sure if this could be done with an option or not, but would be cool to see this in core.

Line 19

-  memberSyntaxSortOrder = configuration.memberSyntaxSortOrder || ["none", "all", "multiple", "single"],
+  memberSyntaxSortOrder = configuration.memberSyntaxSortOrder || ["none", "all", "named", "default"],

Lines 38-41

-  } else if (node.specifiers.length === 1) {
-    return "single";
-  } else {
-    return "multiple";
+  } else if (node.specifiers[0].type === "ImportDefaultSpecifier") {
+    return "default";
+  } else {
+    return "named";

Line 153

-  "enum": ["none", "all", "multiple", "single"]
+  "enum": ["none", "all", "named", "default"]

You can see my full implementation over here: https://github.com/wyze/eslint-plugin-wyze

Curious on your thoughts and feedback.

[nzakas]

No team members stepped forward to champion this change, so closing.