class-methods-use-this rule doesn't consider existence of getters and setters

Currently class-methods-use-this rule is ignoring existence of getters and setters in javascript.

Let’s consider an approach to have proper getter and setter for an object.

// originally bar was a storage engine
let bar;

class Foo {
  get bar() {
    return bar;
  }
  set bar(value) {
    bar = value;
  }
}

After that, eslint was starting to complain that get bar() should use this.

I read the manual which says if method doesn’t use this, it should be a static method. Which doesn’t make much sense for getters, since static getter won’t be executed for instantiated class.

Then, to comply to eslint rule, I’ll need to not use getter or setter and stick to the setBar(), getBar() methods which can be fine, but I think eslint should be wise enough to detect getters special type of functions.

I checked the rule code, and it seems like the isInstanceMethod() function should be changed.

[nzakas]

I think the rule is working as intended, as this is an edge case. I’d say the only possibility here is add an option that allows you to opt out of checking accessor properties.

[BridgeAR]

When extending Errors you want to add a getter for the name and maybe also add some attributes that you do not want to be allowed to be changed at all. So you wouldn’t add a setter for these entries.

class CustomError extends Error {
  get name() {
    return 'CustomError'; // Could also be written as: this.constructor.name
  }
  get code() {
    return 400; // Static value that should not be changed
  }
}