Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Comma dangle syntax no longer ignores functions: never

See original GitHub issue

Tell us about your environment

  • ESLint Version: Upgraded from 6.51 to 6.8.0
  • Node Version: v13.12.0
  • npm Version: Using yarn: 1.22.4

What parser (default, Babel-ESLint, etc.) are you using? Babel-ESLint Please show your full configuration:

extends: airbnb
parser: babel-eslint
  browser: true
  arrow-parens: [warn, always]
  comma-dangle: [warn, always-multiline, { "functions": never }]
  import/prefer-default-export: 0
  jsx-quotes: [warn, prefer-single]
  max-len: [warn, { code: 80 }]
  object-curly-newline: ["warn", { "multiline": true, "consistent": true }]
  operator-linebreak: [warn, after]
  radix: [warn, as-needed]
  react/destructuring-assignment: [warn, always, { ignoreClassFields: true }]
  react/jsx-filename-extension: 0
  react/jsx-props-no-spreading: 0
  react/state-in-constructor: 0
      config: './config/webpack/custom.js'

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

const store = createStore(
  combineReducers({ ...reducers }),
yarn lint

What did you expect to happen? No warnings. My .eslintrc specifies

comma-dangle: [warn, always-multiline, { "functions": never }]

which worked prior to this upgrade

What actually happened? Please include the actual, raw output from ESLint.

warning  Missing trailing comma  comma-dangle

Are you willing to submit a pull request to fix this bug? No

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

mdjermanoviccommented, Jun 12, 2020

Marked as accepted. PR #13166 to fix this is prepared, we’re just not sure whether this can be a semver-minor fix or should we treat it as a breaking change.

kaicataldocommented, Jun 12, 2020

@mdjermanovic Do you mind marking this as accepted if you’ve verified this bug and outlining what you believe the correct fix is here? That way someone from the community could pick this up!

Read more comments on GitHub >

github_iconTop Results From Across the Web

comma-dangle - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
tslint - Missing trailing comma (trailing-comma) on the last line
So...disable it by making that "never" (if you want to disallow commas there) or "ignore" (if you want to allow commas to be...
Read more >
How to Allow Trailing Commas (Comma-Dangle) With ...
Concrete configurations are off , never , ignore , only-multiline , and always-multiline . Adjust the configuration to your needs for each type....
Read more >
comma-dangle | typescript-eslint
This rule extends the base eslint/comma-dangle rule. It adds support for TypeScript syntax. See the ESLint documentation for more details on the ...
Read more >
Options - Prettier
Options · Print Width · Tab Width · Tabs · Semicolons · Quotes · Quote Props · JSX Quotes · Trailing Commas.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found