question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

default ignore node_modules inside monorepos

See original GitHub issue

The version of ESLint you are using.

5.0.0-alpha.2

The problem you want to solve.

I’d like to configure standard in the root of my monorepo. By default eslint only ignores top level node_modules. I see no reason why I’d want to lint any node_modules folder by default. The problem can be worked around by providing extra configuration. But most people wouldn’t want their inner node_modules linted. So I’d like to save those people the hassle of figuring this out and provide it as default. Relevant issue https://github.com/standard/standard/issues/1182

Your take on the correct solution to problem.

I didn’t dig through the code yet but I’m assuming there’s a default defined for ignoring. I’d like this default changed to **/node_modules/

PS. I don’t mind cooking up a PR for this

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:5
  • Comments:8 (3 by maintainers)

github_iconTop GitHub Comments

3reactions
kaicataldocommented, Aug 28, 2018

This does seem like a sane default to me, though I’d be hesitant about changing this in a non-major release.

0reactions
eslint-deprecated[bot]commented, Dec 15, 2018

Unfortunately, it looks like there wasn’t enough interest from the team or community to implement this change. While we wish we’d be able to accommodate everyone’s requests, we do need to prioritize. We’ve found that issues failing to reach accepted status after 21 days tend to never be accepted, and as such, we close those issues. This doesn’t mean the idea isn’t interesting or useful, just that it’s not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

Read more comments on GitHub >

github_iconTop Results From Across the Web

node modules - Git - Ignore node_modules folder everywhere
Add node_modules/ or node_modules to the .gitignore file to ignore all directories called node_modules in the current folder and any subfolders like the ......
Read more >
Turning a Node.js Monolith into a Monorepo without ... - InfoQ
Let's discuss ways to smoothly turn a monolithic Node.js codebase into a Monorepo, while minimizing disruptions and risks.
Read more >
git ignore file node modules Code Example - Code Grepper
echo "node_modules/" >> .gitignore //this adds node_modules to gitignore. 3. cat .gitignore //checks what files you have in your gitignore.
Read more >
Things I wish I had known when I started JavaScript monorepo ...
Entire dependency tree after running npm install (in root level of the monorepo) exists exclusively in root level ./node_modules/ directory.
Read more >
node_modules folders should be "excluded" by default
Open it in WebStorm · Run npm install (and wait for it to finish) (Note that this will add many node_modules folders, and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found