question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Deprecate Node-specific core rules

See original GitHub issue

The version of ESLint you are using. master

The problem you want to solve.

The number of rules in core has grown to the point that we have to set a very high bar for new rules. To improve our ability to maintain core, I think it makes sense to treat the current core Node/CommonJS rules similarly to how we handled the deprecation of core JSDoc rules. I believe these are the last runtime/library specific rules that we have in core, and think this also makes sense for the sake of consistency.

Your take on the correct solution to problem.

As discussed in our TSC meeting (notes here), this proposal is to deprecate all the Node/CommonJS-specific rules in core and to move all of them into eslint-plugin-node, maintained by @mysticatea.

Are you willing to submit a pull request to implement this change? Yes!

Questions

  1. @mysticatea Are you still okay with this? Just wanted to check because it’s been a little while since we last discussed this.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:5
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
mysticateacommented, Feb 8, 2020

Thank you for this issue.

Are you still okay with this? Just wanted to check because it’s been a little while since we last discussed this.

Yes!

0reactions
ljharbcommented, Apr 3, 2020

I know it might be late, but this seems like a terrible idea. Having rules in core is paramount for discoverability, especially since shared configs and peer deps are still a huge PITA, until shared configs can bring along plugins as regular deps.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Working with Rules (Deprecated) - Pluggable JavaScript Linter
Important: If you submit a core rule to the ESLint repository, ... If both loc and node are specified, then the location is...
Read more >
Approaches to Deprecating Code in JavaScript | CSS-Tricks
First, let's start by clarifying that the deprecation is just a status applied to a software feature. It indicates that this feature should...
Read more >
Understanding the Buffer Deprecation in Node.js 10
js Buffer constructor is rather simple: deprecate the Buffer constructor outside of node_modules . This gets around users being stuck with ...
Read more >
npm WARN deprecated core-js@2.6.11: core-js@<3 is no ...
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, ...
Read more >
Deprecated and obsolete features - JavaScript - MDN Web Docs
This section is described as normative optional — that is, web browser hosts must implement these features, while non-web hosts may not. These ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found