Dots at the end of many messages are omitted

What version of ESLint are you using? 3.1.1 What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration: Example for array-bracket-spacing but this issue is not limited to this rule only -

{
    "rules": {
        "array-bracket-spacing": "error"
    }
}

What did you do? Please include the actual source code causing the issue.

var foo = [ ]

What did you expect to happen? Have a dot at the end - 1:11 error There should be no space after '['. array-bracket-spacing

What actually happened? Please include the actual, raw output from ESLint. It doesn’t have a dot at the end - 1:11 error There should be no space after '[' array-bracket-spacing

I’m not sure if this is intentional or not, every message should have a dot at the end or there is a different policy in place? If so, I think it should be documented.

Beside that, if this is really a “bug” I think every rule should be fixed with one commit in order not to trash the commit history

[ilyavolodin]

I know that keeping all of the error messages in the same style is important, but is it important enough to add something like that to RuleTester, or create additional complexity in some other way? I think we should just go through and add dots at the end of every message. Sometime in the future we can just do another pass. It’s not like it takes all that much time.

[markelog]

@vitorbal

We could add a custom internal rule for checking that the last dot is always present

You mean custom ESLint rule? I’m not sure if that is possible for static analysis tool, for example, you would need to deal with cases like that - https://github.com/eslint/eslint/blob/ddea63a6dbc73e9ef2c2c5625826d02d586de774/lib/rules/array-bracket-spacing.js#L78

@pmcelhaney

Okay, maybe a check for proper formatting can be added to rule-tester.js.

I think this is our best bet, it shouldn’t reflect on rules which are not part of our repo, so we wouldn’t need to bump major or anything like that