Enhancement of 'no-else-return' rule

What rule do you want to change? no-else-return

Does this change cause the rule to produce more or fewer warnings? more

How will the change be implemented? (New option, new default behavior, etc.)? adding some options / extension to this rule.

Please provide some example code that this change will affect:

if(something) {
   throw new Error();
} else {
  return true;
}
---
if(something) {
   throw new Error();
}
return true;

if(something) {
  return 1;
} else if(sthMore) {
  return 2;
}
---
if(something) {
  return 1;
}
if(sthMore) {
  return 2;
}

if(something) {
  return 1;
} else {
  throw new Error();
}
---
if(something) {
  return 1;
}
throw new Error();

What does the rule currently do for this code? it does sometimes work for the last case. it doesn’t change if else statements.

What will the rule do after it’s changed? adds support for Errors - they ‘work quite similar to returns’ adds support for if else

Are you willing to submit a pull request to implement this change? unfortunatelly don’t have time. Could help with some information

[anikethsaha]

hmmm it seems it doesn’t work in some cases, or with Typescript itself

We dont support typescript in core rules. Please use typescript-eslint for config and plugins

function h(){
if(something) {
  throw new Error();
} else if(sthMore) {
  return 2;
}
}

it seems to not be working

because this rule is not about throw statements. as per the docs

If an if block contains a return statement, the else block becomes unnecessary. Its contents can be placed outside of the block.

So even if there is an interest to support throw, IMO it has to be in a separate new rule.

[eslint-deprecated[bot]]

Unfortunately, it looks like there wasn’t enough interest from the team or community to implement this change. While we wish we’d be able to accommodate everyone’s requests, we do need to prioritize. We’ve found that issues failing to reach accepted status after 21 days tend to never be accepted, and as such, we close those issues. This doesn’t mean the idea isn’t interesting or useful, just that it’s not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.