Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

eqeqeq rule allow-undefined

See original GitHub issue

What rule do you want to change?

Require === and !== (eqeqeq)

Does this change cause the rule to produce more or fewer warnings?

In ECMA262:

null value is primitive value that represents the intentional absence of any object value.

undefined value is primitive value used when a variable has not been assigned a value.

In TypeScript team coding guidelines:

Use undefined. Do not use null.

So i think comparing with the undefined literal should also can be allowed.

How will the change be implemented? (New option, new default behavior, etc.)? Please support allow-undefined.

Please provide some example code that this change will affect:

foo == null
foo == undefined

What does the rule currently do for this code?

foo == null // correct
foo == undefined // incorrect

What will the rule do after it’s changed?

foo == null // correct
foo == undefined // correct

Are you willing to submit a pull request to implement this change?

It’s my pleasure

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:5
  • Comments:26 (14 by maintainers)

github_iconTop GitHub Comments

kaicataldocommented, Aug 4, 2020

I don’t think this change should be made in core for a few reasons:

  1. Since this is purely stylistic, it falls under our new policy.

  2. If you’re never using null, why not just use a === undefined everywhere? It would be safer and more explicit. The way I read this guideline is that you should never use null to represent a null value for APIs you control. That doesn’t mean you wouldn’t have to use a === null in your code, since there’s a good chance you’ll be interacting with someone else’s code (even if it’s just the Node builtin or DOM APIs) that may return null.

SyMindcommented, Aug 20, 2020

Also note that the undefined literal can be redefined, everywhere but the global scope. == null is the only safe usage of ==.

In the ECMA262 specification, [[Writable]] of undefined is false. So i don’t think is problem to use undefined in 2020.

The value of undefined is undefined (see 6.1.1). This property has the attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }.

And most people use feature like ES Module and Class, they are always in strict mode. In strict mode will throw TypeError when undefined = anything.

I don’t agree - null isn’t buggy.

In the following url, Brendan Eich say in 2011/01/14 20:18:

I would very much prefer to fix typeof. We talked about this before, and decided that there is code out there that depends on typeof ‘s bad behavior. Are we now saying that the migration tax is acceptable?

Obviously, this is a bug that the author agreed.

Read more comments on GitHub >

github_iconTop Results From Across the Web

eqeqeq - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
angular-eslint/template/eqeqeq Disable or allow null
So I tried to completely disabled the rule, like this: ... documentation regarding that rule. Can I disable it or allow double equal...
Read more >
angus on Twitter: "@ripter001 you can use the "smart" option for ...
`if(value === null || value === undefined)` is still everywhere even though ... you can use the "smart" option for eslint's eqeqeq rule...
Read more >
Rule eqeqeq - ESLint中文文档
This rule is aimed at eliminating the type-unsafe equality operators. ... eslint eqeqeq: [2, "smart"] */ typeof foo == 'undefined' 'hello' !=
Read more >
Rule eqeqeq - ESLint中文
This rule is aimed at eliminating the type-unsafe equality operators. ... permits comparing to null to check for null or undefined in a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found