Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

eslint 2.4.0 has a missing dependency of estraverse-fb

See original GitHub issue

What version of ESLint are you using? 2.4.0

What parser (default, Babel-ESLint, etc.) are you using? babel-eslint

Please show your full configuration: https://github.com/mozilla/web-ext/blob/0ce1debe0546559fd79ec43523250f776148749f/.eslintrc

What did you do? Please include the actual source code causing the issue. Upgraded babel-eslint

What did you expect to happen? I expected my eslint configuration to work just like before.

What actually happened? Please include the actual, raw output from ESLint. I get this traceback:

Error: Cannot find module 'estraverse-fb'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at monkeypatch (/home/travis/build/mozilla/web-ext/node_modules/babel-eslint/index.js:59:32)
    at Object.exports.parse (/home/travis/build/mozilla/web-ext/node_modules/babel-eslint/index.js:385:5)
    at parse (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/eslint.js:577:27)
    at EventEmitter.module.exports.api.verify (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/eslint.js:715:19)
    at processText (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/cli-engine.js:187:27)
    at processFile (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/cli-engine.js:227:18)
    at executeOnFile (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/cli-engine.js:603:23)
    at /home/travis/build/mozilla/web-ext/node_modules/eslint/lib/cli-engine.js:630:17
    at Array.forEach (native)
    at CLIEngine.executeOnFiles (/home/travis/build/mozilla/web-ext/node_modules/eslint/lib/cli-engine.js:625:18)
    at Object.<anonymous> (/home/travis/build/mozilla/web-ext/node_modules/grunt-eslint/tasks/eslint.js:38:20)
    at Object.<anonymous> (/home/travis/build/mozilla/web-ext/node_modules/grunt/lib/grunt/task.js:264:15)
    at Object.thisTask.fn (/home/travis/build/mozilla/web-ext/node_modules/grunt/lib/grunt/task.js:82:16)
    at Object.<anonymous> (/home/travis/build/mozilla/web-ext/node_modules/grunt/lib/util/task.js:301:30)
    at Task.runTaskFn (/home/travis/build/mozilla/web-ext/node_modules/grunt/lib/util/task.js:251:24)
    at Task.<anonymous> (/home/travis/build/mozilla/web-ext/node_modules/grunt/lib/util/task.js:300:12)
    at /home/travis/build/mozilla/web-ext/node_modules/grunt/lib/util/task.js:227:11
    at process._tickDomainCallback (node.js:381:11)

You can see my failing test run here: https://travis-ci.org/mozilla/web-ext/jobs/115443944

This was originally reported in https://github.com/eslint/eslint/issues/5476 but the fix for it (https://github.com/eslint/eslint/commit/97b24668b390b398225e8ef1bc817d6a0d1a4c59) does not appear to declare estraverse-fb as a direct dependency – unless I missed it.

Issue Analytics

State:
Created 8 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

swillard-r7commented, Mar 14, 2016

@hzoo I can confirm that the 6.x (latest beta) fixes this issue with eslint.

On a slightly unrelated note, I guess things were renamed in babel-eslint 6 from 5, so I’m getting several errors

  6:1  error  Rule 'no-empty-label' was removed and replaced by: no-labels                 no-empty-label
  6:1  error  Rule 'space-before-keywords' was removed and replaced by: keyword-spacing    space-before-keywords
  6:1  error  Rule 'space-after-keywords' was removed and replaced by: keyword-spacing     space-after-keywords
  6:1  error  Rule 'space-return-throw-case' was removed and replaced by: keyword-spacing  space-return-throw-case

0reactions

ilyavolodincommented, Mar 14, 2016

Closing this since it’s been fixed.

Top Results From Across the Web

eslint 2.3.0 has a missing dependency of estraverse #5476

What version of ESLint are you using? 2.3.0. What configuration and parser (Espree, Babel-ESLint, etc.) are you using? babel-eslint.

How to fix missing dependency warning when using useEffect ...

I have this current setup, React hook useEffect runs continuously forever/infinite loop and the only comment is about useCallback() which I'm not familiar...

How To Fix "react hook useeffect has a missing dependency"?

Move the dependency inside the useEffect hook; Disable the ESLint rule. This article will explore all of those options and show examples. Let's ......

eslint-plugin-dependencies - npm package - Snyk

Is eslint-plugin-dependencies safe to use? The npm package eslint-plugin-dependencies was scanned for known vulnerabilities and missing license, and no issues ...

eslint-plugin-dependencies - npm

Prevents cyclic references between modules. It resolves require("…") , import "…" and export … from "…" references to internal modules (i.e. not ...