eslint-recommended changes in eslint v6.0.0

Similar to previous release, new rules can be added to eslint:recommended(https://github.com/eslint/eslint#semantic-versioning-policy)

some candidates:

• require-unicode-regexp

• no-misleading-character-class

• no-async-promise-executor

• require-atomic-updates

• reconsider rules like eval, no-implied-eval, no-new-func. (https://github.com/eslint/eslint/issues/9406#issuecomment-335983858)

• no-console

• no-mixed-spaces-and-tabs: enable smart-tabs options.

• no-shadow-restricted-names

• no-prototype-builtins

• https://github.com/eslint/eslint/issues/11279 (not accepted/implemented yet)

• no-useless-catch

• no-with

[not-an-aardvark]

Personally, I’m convinced that no-prototype-builtins is worth adding. I suspect a majority of hasOwnProperty usages are buggy even if no one has discovered the bug yet, due to the possibility that hasOwnProperty can be shadowed in user-provided objects. (hasOwnProperty is only useful for objects where the set of keys isn’t known at development time, and that’s precisely the case where one of the keys could shadow Object.prototype.)

To me, this is a case where developers can either (a) use a terse notation that is occasionally subtlely wrong, or (b) use a more verbose notation that doesn’t have those problems. So my opinion is that always doing (b) is an easy choice, and enforcing against the buggy choice is important for developers who might not be aware of the subtle bug.

[not-an-aardvark]

It seems like we need a full proposal to decide on. I’ll propose the following:

---

Add the following rules to eslint:recommended:

• no-misleading-character-class
• no-async-promise-executor
• require-atomic-updates
• no-shadow-restricted-names
• no-useless-catch
• no-with
• no-prototype-builtins

Remove the following rule:

• no-console