Exemption for for...of unused variable.

In similar vein to for...in https://github.com/eslint/eslint/issues/2342 Should there be similar exemption for [async] for...of?

What rule do you want to change? no-unused-vars

Does this change cause the rule to produce more or fewer warnings? fewer warnings

How will the change be implemented? (New option, new default behavior, etc.)? I don’t know

Please provide some example code that this change will affect:

async function forever(x) {
  for await (const unused of x) {
    void unused;
  }
}

forever(monitor_network());

What does the rule currently do for this code? Line 42: 'unused' is defined but never used no-unused-vars

What will the rule do after it’s changed? Nothing

Are you willing to submit a pull request to implement this change? This seems tricky…

[dimaqq]

I’m so sorry for the confusion.

When I read #2342 I was left with the impression that the following is allowed:

for (unused in something) {}

But of course that’s only because unused could be anything here, e.g. a global, and other rules kick in now: no-undef, prefer-const.

It didn’t think that the following is semantically different wrt. the unused variable rule and treated both cases the same:

for (const unused in something) {}

Weirdly there’s test case for the above, as if that’s valid code: https://github.com/eslint/eslint/blob/76fb571a1c15b040e42272435eb0d023cdcb031e/tests/lib/rules/no-unused-vars.js#L159 Yet, if I “enable all rules” in the eslint demo, that very example triggers no-unused-vars 😕

In any case void unused; works and keeps eslint silent.

Also, as far I can tell for await (const x of y) is treated exactly same as for (const x of y).

I guess I’m OK then 😃

[kaicataldo]

Note that this issue doesn’t show in the ESLint Demo .

Are you using babel-eslint?