question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

extend eslint:all to include plugins

See original GitHub issue

The version of ESLint you are using.

6.5.1

The problem you want to solve.

This is a followup to https://github.com/eslint/eslint/issues/6240 and https://github.com/eslint/eslint/pull/6248. The eslint:all configuration has been working great on our projects. However, some plugins implement a similar all configuration and some don’t. It’s a pain for every plugin maintainer to have to implement a similar rule, and in some cases they are unwilling to implement it. We would like to be able to enable all ESLint rules across all of our plugins by default, then configure them away from the defaults where appropriate. A couple of my previous comments for way more context:

https://github.com/eslint/eslint/issues/6240#issuecomment-221123719 https://github.com/eslint/eslint/issues/6240#issuecomment-223716227

Your take on the correct solution to problem.

ESLint should have an option to enable all rules across plugins, not just the built in rules.

Are you willing to submit a pull request to implement this change?

I’m happy to implement something like this with guidance. I implemented the eslint:all rule, but it looks like plugin rules are loaded separately from builtin rules, so it might be somewhat more complicated to implement.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:10 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
platinumazurecommented, Oct 25, 2019

I’ve thought about it some more, and I think I’m also slightly opposed on cost/benefit grounds.

I’m wary of more support questions that might come in because someone is using the ESLint core “enable all rules from a plugin”, even though 99% of those questions should go to the plugin owner. The benefit of this change does not justify the maintenance/support cost, in my view.

1reaction
kaicataldocommented, Oct 24, 2019

I don’t really see the value in this (the benefits don’t seem to outweigh the increased confusion/support we might have to offer users), but if other members of the team are for it, I’ll defer to consensus.

I’ve removed my 👎.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Working with Plugins - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
What's the difference between plugins and extends in eslint?
extends uses a config file which applies set of rules when you add that to the extends options. A plugin on the other...
Read more >
What is the difference between extends and plugins in ESLint ...
ESLint plugins allow you to add custom rules according to the needs of your project. Plugins are published as npm modules with names...
Read more >
17. Add the config rules in the Plugin and extend ... - YouTube
... see how to create the rules in the plugin so that it will be loaded default when somebody uses and extends the...
Read more >
How ESLint Resolves Plugins And Shareable Configs
Plugin — can do everything that a shareable config does + might include custom rules. Example: eslint-plugin-jest. For more practical examples, https:// ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found