False positive with `callback-return` rule

ESLint 1.1.0. Concerning the callback-return rule.

Config

'callback-return': [2, ['cb', 'callback']]

Problem

function foo(bool, bool2, cb) {
    function bar() {
        if (bool2) {
            console.log('foo');
            cb();
        }
    }

    if (bool) {
        bar();
    } else {
        cb();
    }
}

I have many instances of this and similar code where I have a conditional whether to do something more or callback right away.

In the above example, both of the cb calls violates the callback-return rule. It should not however, as there is no code running after the cb() calls. So it’s totally safe.

Some real examples:

• https://github.com/sindresorhus/gulp-size/blob/40c6c9af54046b7b45cf5b2e3df128da8236306c/test.js#L21
• https://github.com/sindresorhus/gulp-size/blob/40c6c9af54046b7b45cf5b2e3df128da8236306c/test.js#L82
• https://github.com/sindresorhus/gulp-size/blob/40c6c9af54046b7b45cf5b2e3df128da8236306c/test.js#L104

<bountysource-plugin>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[xjamundx]

I’d really love to figure this one out as I think it can add a ton of value. Just leave it closed and if I can figure out how to do it with the code path stuff I’ll shout.

[nzakas]

This has been open for over a year and several team members have indicated that this is quite difficult, so closing.