Have 'func-name-matching' ignore defineProperty function values by default

What rule do you want to change?

func-name-matching

Does this change cause the rule to produce more or fewer warnings?

Fewer.

How will the change be implemented? (New option, new default behavior, etc.)?

New default behavior where we allow { value } property descriptor a different name than value.

Please provide some example code that this change will affect:

var model = {};

Object.defineProperty(model, 'key', {
  value: function key() {
    //
  }
});

console.log(model.key.name); // logs 'key'

What does the rule currently do for this code?

Function name key should match property name value

What will the rule do after it’s changed?

No error.

[platinumazure]

Thanks @ljharb, your point is well taken.

Let’s step back a bit and just follow our process. If the team champions and endorses not only the standard property-descriptor functions, but also user-configurable ones, then that’s what we’ll implement. If the team champions and endorses just the standard property-descriptor functions, then we’ll implement that instead and we can re-evaluate later if we get more demand for customizability. (And until that point, @ljharb can certainly create a custom rule for his use case.)

I’m 👍 for the standard property descriptor functions for sure-- it should be fairly easy to do. I’m not outright opposed to customizations, but I’m not yet convinced we have enough demand from the community just yet.

[mysticatea]

Sounds reasonable to me.

Object.defineProperty(model, 'foo', {
  value: function foo() {
    //
  },
  enumerable: true,
  configurable: true,
  writable: true
});

This is same as

model.foo = function foo() {
    //
};

The function foo is the value of model.foo. Also, function value in the stacktrace is not helpful to developers. value does not express what the function is. It should be foo. So I think the rule should enforce the name to foo rather than value.

Object.defineProperty(model, 'foo', {
    value: function value() {  //※ Function name `value` should match property name `foo`.
        //
    }
});

Object.defineProperties(model, {
    foo: {
        value: function value() {  //※ Function name `value` should match property name `foo`.
            //
        }
    }
});

Object.defineProperty(model, 'foo', {
    value: function foo() {  //※ OK
        //
    }
});

Object.defineProperties(model, {
    foo: {
        value: function foo() {  //※ OK
            //
        }
    }
});