ignore node_modules folder by default [$15 awarded]

Sorry, I searched but couldn’t find an existing issue for this…

---

Should ESLint ignore the “node_modules/**” folder by default?

I have a sample Node project with one *.js file (and ESLint installed globally) and typed:

$ eslint .

...
node_modules/syntax-error/test/sources/check.js
  5:30  error  Unexpected identifier

✖ 88164 problems

real    0m33.670s
user    0m30.912s
sys     0m0.958s

The command took ~30s and found 88k problems in my node_modules/ folder. 😕 I think we’d want to automatically ignore the “node_modules/**” folder since it’d be a better “out of the box” experience.

Workaround:

Put node_modules/** in the project’s .eslintignore file.

$ echo "node_modules/**" > .eslintignore

$ cat .eslintignore
node_modules/**

$ time eslint .

index.js
  1:0  error  'console' is not defined      no-undef
  1:0  error  Unexpected console statement  no-console

node_modules/hapi/test/templates/valid/helpers/.hidden.js
  1:16  error  Strings must use doublequote  quotes

✖ 3 problems

real    0m0.346s
user    0m0.293s
sys     0m0.053s

Not sure why, but even though I have node_modules/** in my .eslintignore file, it looks like it’s linting node_modules/hapi/test/templates/valid/helpers/.hidden.js.

<bountysource-plugin>

The $15 bounty on this issue has been claimed at Bountysource. </bountysource-plugin>

[nzakas]

Yeah, thanks, I understand now. I’m quite hesitant to add too many ignored directories by default. node_modules/** makes me confident that we’re handling the most important case, **/node_modules/** scares me a bit because it’s an uncommon use and therefore I’m not sure if we can derive any sort of meaning from that directory structure.

In this case, I’d much rather allow projects to opt-in to **/node_modules/** if they need it rather that doing it automatically.

[wavded]

Fair enough, thx.