indent flatTernaryExpressions is broken when conditions and values are on the same line

• ESLint Version: 4.0.0-alpha.0
• default parser

/*eslint indent: [2, 4, {"flatTernaryExpressions": true}] */

var foo =
    d >= 10 ? 10 :
    d >= 5 ? 5 :
    d >= 2 ? 2 :
    d >= 1 ? 1 : 0;

What did you expect to happen? No errors.

What actually happened?

   5:1  error  Expected indentation of 8 spaces but found 4  indent
   6:1  error  Expected indentation of 8 spaces but found 4  indent
   7:1  error  Expected indentation of 8 spaces but found 4  indent

ESLint suggest the following formatting, which doesn’t make sense:

var foo =
    d >= 10 ? 10 :
        d >= 5 ? 5 :
        d >= 2 ? 2 :
        d >= 1 ? 1 : 0;

BTW, I strongly believe that flatTernaryExpressions should be true by default. I’ve never in my life seen this zigzag-style ternary formatting in any projects, while the flat style is pretty much everywhere.

Thanks a lot! Apart from this nitpick, the new indent rule is really awesome! Worked great on a 40k-line project I maintain.

cc @not-an-aardvark @mysticatea

[mysticatea]

I know indentation is very complex… I will get time in the next week, a long vacation in Japan, so I will investigate this.

[mysticatea]

// case 3
var foo = {
    ok: true
};

// case 4
var foo =
    {
        ok: true
    };

// case 5
var foo = {
        ok: true
    },
    bar = 3;

I think the case 3 is a special case. The initializer expression body has own indentation level of the object literal, so people probably want to avoid over indentation. However, I think initializer expressions have one indentation basically.