`indent`: `outerIIFEBody` option not using a multiplier, warning on non-IIFEs?

What version of ESLint are you using? v3.0.0

What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration:

eslint --rule indent:[2,2,{outerIIFEBody:1}] file.js

What did you do? Please include the actual source code causing the issue. https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/test/test-base.js

import fs from 'fs';
import path from 'path';
import test from 'tape';

import index from '../';

const files = { index };

fs.readdirSync(path.join(__dirname, '../rules')).forEach(name => {
  files[name] = require(`../rules/${name}`); // eslint-disable-line global-require
});

Object.keys(files).forEach(name => {
  const config = files[name];

  test(`${name}: does not reference react`, t => {
    t.plan(2);

    // scan plugins for react and fail if it is found
    const hasReactPlugin = Object.prototype.hasOwnProperty.call(config, 'plugins') &&
      config.plugins.indexOf('react') !== -1;
    t.notOk(hasReactPlugin, 'there is no react plugin');

    // scan rules for react/ and fail if any exist
    const reactRuleIds = Object.keys(config.rules)
      .filter(ruleId => ruleId.indexOf('react/') === 0);
    t.deepEquals(reactRuleIds, [], 'there are no react/ rules');
  });
});

What did you expect to happen? No warnings.

What actually happened? Please include the actual, raw output from ESLint.

$PWD/packages/eslint-config-airbnb-base/test/test-base.js
  10:3  error  Expected indentation of 1 space character but found 2  indent
  14:3  error  Expected indentation of 1 space character but found 2  indent
  16:3  error  Expected indentation of 1 space character but found 2  indent

There are two problems here:

1. the warned lines are not actually file-level IIFEs - the file doesn’t have an IIFE at all.
2. outerIIFEBody is set to 1 - this should be a multiplier of 1 on the indentation config of “2 spaces” - the errors indicate that it wants “1 space” which should never be required when the base indent is “2”.

[alberto]

@nzakas should we also cover the cases @wojdyr mentioned?

[nzakas]

@platinumazure let’s keep the scope of this issue narrow - there’s no need to talk about future long-term possibilities in this context as it’s confusing for everyone involved.

This option should definitely act like the others and be a multiplier. I’ll take a look and see if it’s something that can be fixed easily.