Modify overrides to also override/add globals

The version of ESLint you are using. v4.19.1

The problem you want to solve. For test files within our lib directory, we’d like to specify mocha-specific globals like it and describe, but ideally we wouldn’t allow those globals in product code.

Your take on the correct solution to problem. It seems like overrides provides the perfect solution here – but as far as I can tell it only overrides rules right now, so we can’t use it to add globals. Can overrides easily be modified to define a new set of globals as well?

Thanks!

[platinumazure]

Hi @thomascmost, thanks for the issue.

At the very least, you should be able to use environments (env) to enable the Mocha environment, which enables the Mocha globals (although, unfortunately, you don’t get fine-grained control of what globals to allow and disallow-- you could use no-restricted-globals to work around that if needed).

That said, it would be nice to handle globals in overrides. I’ll mark this as a core enhancement request.

[mysticatea]

overrides supports globals and other properties since v4.1.0.

• A glob specific configuration works almost the same as any other ESLint config. Override blocks can contain any configuration options that are valid in a regular config, with the exception of extends, overrides, and root.

https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns